New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Stream.php #332

Merged

nyamsprod merged 1 commit into thephpleague:master from unknown repository

Feb 26, 2019

+5 −2

ghost commented Feb 26, 2019

Fix the seek method in League\Csv\Stream.php. If the $position parameter is 0, $offset will become -1.


          Update Stream.php

28c3a70

Fix the seek method in League\Csv\Stream.php. If the $position parameter is 0, $offset will become -1.

Member

nyamsprod commented Feb 26, 2019 •

edited

Loading

could you:

add the tests in StreamTest.php
use Yoda style in the if condition

and I'll merge your fix

thanks in advance

nyamsprod self-assigned this

nyamsprod added the bug label

nyamsprod merged commit b1f1516 into thephpleague:master

nyamsprod added a commit that referenced this pull request


          Merged PR #332 improved with tests

5ad1aa2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug