Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export with quality of 1 fails #12

Closed
MAKIO135 opened this issue May 14, 2020 · 1 comment
Closed

Export with quality of 1 fails #12

MAKIO135 opened this issue May 14, 2020 · 1 comment

Comments

@MAKIO135
Copy link

When setting quality to 1, WebMWriter fails to export video since there is no space after VP8 in the generated binary.

keyframeStartIndex = webP.indexOf('VP8 ');

Workaround is to set quality to 0.99 but just wanted to let you know, maybe just to constrain quality to 0.99.

Except for this, the library works just fine, I'm using it to export canvas loops (https://observablehq.com/@makio135/bnb) thanks a lot 🙏

@thenickdude
Copy link
Owner

Thanks for the bug report, I've now fixed it so that quality = 1.0 gets clamped down to 0.99999 automatically. (Quality 1.0 was generating VP8L lossless frames, which don't appear to be supported in WebM)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants