fix(toggleswitch): disable + checked state and deprecated html event replacement #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rluders
force-pushed
the
fix/toggleswitch-state
branch
from
aea21c2 to
f65d382
Compare
rluders
force-pushed
the
fix/toggleswitch-state
branch
from
f65d382 to
796c795
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #987 +/- ##
==========================================
- Coverage 99.54% 93.46% -6.09%
==========================================
Files 163 182 +19
Lines 6621 7896 +1275
Branches 401 440 +39
==========================================
+ Hits 6591 7380 +789
- Misses 30 516 +486
☔ View full report in Codecov by Sentry. |
SutuSebastian
approved these changes
Sep 24, 2023
added 4 commits
September 24, 2023 09:37
This commit fixes the state for disable + enabled ToggleSwitch and also replaces the deprecated onKeyPress with onKeyDown fix themesberg#986
rluders
force-pushed
the
fix/toggleswitch-state
branch
from
3d0185e to
3f879e7
Compare
maman
pushed a commit
to transkripid/flowbite-react
that referenced
this pull request
Oct 7, 2023
…replacement (themesberg#987) * docs: add disabled+active toggleswitch example * fix(toggleswitch): fix state and replace onkeypress with onkeyup This commit fixes the state for disable + enabled ToggleSwitch and also replaces the deprecated onKeyPress with onKeyDown fix themesberg#986 * fix(toggleswitch): remove unused event * refactor(toggleswitch): remove dead code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #986 the component
ToggleSwitchwasn't acting as expected whenchecked={true} disabled={true}. This PR fixes the issue. This also replaces the deprecatedonKeyPressAPI withonKeyDown.Fixes #986
onKeyPresswithonKeyDown. It should not break anything, since the API is only internally used.