Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow icon (chevron) inside Sidebar.Collapse is not accessible via props or the flowbite theme #888

Closed
2 tasks done
MaSchVam opened this issue Jul 30, 2023 · 1 comment · Fixed by #891
Closed
2 tasks done
Labels
good first issue Good for newcomers 🚀 enhancement New feature or request

Comments

@MaSchVam
Copy link

  • I have searched the Issues to see if this bug has already been reported
  • I have tested the latest version

Summary

The chevron/arrow icon in the <Sidebar.Collapse /> component appears to be hardcoded. It would be nice to have a component prop or a property in the theme that could apply a class to this, based on whether or not it is open.

@rluders rluders added 🚀 enhancement New feature or request good first issue Good for newcomers labels Jul 31, 2023
@rluders
Copy link
Collaborator

rluders commented Jul 31, 2023

Some possible AI for this issue:

  • Add new properties here: chevronIcon and renderChevronIcon;
    • Define a default value for chevronIcon;
    • renderChevronIcon should receive the theme + open state as args;
  • Expand the theme by adding the chevronIcon with on and off styles;
    • Theme for on and off must rotate the chevronIcon;
    • Add some animated transitions to smooth rotation;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers 🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants