-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(button.tsx): Added as prop to button component #826
Conversation
Created 'as' prop that allows the button component to be rendered as any element or functional component fix themesberg#655
Added code example of the `as` prop usage to the Button documentation page
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 163 163
Lines 6621 6632 +11
Branches 401 404 +3
=======================================
+ Hits 6591 6602 +11
Misses 30 30
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nigellima looks nice. I noticed one small detail... in the documentation, for the code sample that you created, when I'm hovering the button that is using span
it doesn't actually change the mouse pointer. I think that would be nice to have it.
51d6f85
to
3f3874c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nigellima.
This is an excellent PR.. @nigellima thank you again |
I noticed |
@Rubens10010 if you don't open an issue it will be lost. |
@Rubens10010 Can you elaborate on what you mean by that about basePath? |
Description
Fixes #655
As @tulup-conner commented here, I decided to create a new PR with the simplest solution based on the SidebarItem component.
Type of change
Please delete options that are not relevant.
Breaking changes
No breaking changes
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: