-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace classnames
by tailwind-merge
#816
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `tailwind-merge`
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In general, you shouldn't need to use
!important
to customize the theme of any component anymore, and you can safely remove its usage anywhere in your Flowbite React themes/customclassName
s.Users normally get confused about the need to use
!
to overwrite the theme classes when usingclassName=
property. This PR includestailwind-merge
that handles the conflicts instead of usingclassNames
.Example:
What this PR does:
Current state:
Type of change
Breaking changes
<Avatar img="somewhere.jpg" theme={..} />
now has aavatar.root.img.base
style to customize the output of the<img/>
. If you were customizing<Avatar>
theme with any ofavatar.root.img
, you might want to check out the changelog: 427a56f (we just moved arounded
fromon
/off
tobase
)How Has This Been Tested?
yarn dev
Checklist:
This is a continuation of #800