Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: making ToggleSwitch color prop as keyof FlowbiteColors #741

Merged
merged 1 commit into from
May 22, 2023

Conversation

IuriPires
Copy link
Contributor

Description

Based on #736 , ToggleSwitch color prop was not defined as keyof FlowbiteColors which was causing a build error.

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #736

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change contains documentation update

Breaking changes

Please document the breaking changes if suitable.

How Has This Been Tested?

Using a project test, I was able to navigete to the type definition and perform the modification on the fly. So the component itself was able to show whether it was working properly or not. After that I built the project and it worked as expected

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@IuriPires
Copy link
Contributor Author

@rluders @davemooreuws could check this out when you guys have time? Thank you!

@IuriPires IuriPires changed the title fix: making color as keyof FlowbiteColors fix: making ToggleSwitch color prop as keyof FlowbiteColors May 13, 2023
@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (974c126) 99.43% compared to head (50f6945) 99.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #741   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files         131      131           
  Lines        6527     6527           
  Branches      490      490           
=======================================
  Hits         6490     6490           
  Misses         37       37           
Impacted Files Coverage Δ
src/lib/components/ToggleSwitch/ToggleSwitch.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@davemooreuws davemooreuws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rluders
Copy link
Collaborator

rluders commented May 22, 2023

Thank you @IuriPires and @davemooreuws

@rluders rluders merged commit e3e2112 into themesberg:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToggleSwitch color: Type 'string' is not assignable to type 'string & FlowbiteColors'.
3 participants