Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): fix dropdown menu items container width #714

Merged
merged 6 commits into from
Apr 25, 2023

Conversation

paghar
Copy link
Contributor

@paghar paghar commented Apr 24, 2023

#575

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change contains documentation update

Breaking changes

Please document the breaking changes if suitable.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@rluders
Copy link
Collaborator

rluders commented Apr 24, 2023

@paghar could you please rebase and fix the conflicts?

Copy link
Collaborator

@tulup-conner tulup-conner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

src/lib/components/Dropdown/Dropdown.tsx Show resolved Hide resolved
src/lib/components/Dropdown/Dropdown.tsx Outdated Show resolved Hide resolved
src/lib/components/Dropdown/Dropdown.tsx Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 90.00% and project coverage change: -0.05 ⚠️

Comparison is base (57cf6e8) 99.43% compared to head (b70bc01) 99.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   99.43%   99.38%   -0.05%     
==========================================
  Files         131      131              
  Lines        6502     6527      +25     
  Branches      488      489       +1     
==========================================
+ Hits         6465     6487      +22     
- Misses         37       40       +3     
Impacted Files Coverage Δ
src/lib/components/Dropdown/Dropdown.tsx 98.14% <88.88%> (-1.86%) ⬇️
src/lib/components/Floating/Floating.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paghar
Copy link
Contributor Author

paghar commented Apr 25, 2023

@tulup-conner @rluders
Problems identified and fixed, Check it again please

Copy link
Collaborator

@tulup-conner tulup-conner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants