fix(component/progressbar): fix progressbar showing label when progress == 0 #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #698 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 130 130
Lines 6479 6480 +1
Branches 485 485
=======================================
+ Hits 6442 6443 +1
Misses 37 37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
rluders
requested changes
Apr 13, 2023
rluders
changed the title
rluders
changed the title
rluders
force-pushed
the
fix-progressbar
branch
from
15807f2 to
b4075b0
Compare
* fix: group list styling * fix: borders between list group items --------- Co-authored-by: Mees van Dongen <[email protected]> Co-authored-by: Ricardo Lüders <[email protected]>
… at progress value is 0 The conditional rendring using the '&&' would return 0 on condition being false which would get displayed when progress value is 0. This was fixed using ternary operator instead. And also the label would get hidden at low progress values which is now fixed. fix themesberg#696
rluders
force-pushed
the
fix-progressbar
branch
from
b4075b0 to
dfcc210
Compare
|
I hope you don't mind @SrivatsaRUpadhya, I changed it a little bit. I want to spin a release this week. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Progress bar shows labels even when it is disabled at progress value is 0
The conditional rendering using the '&&' would return 0 on condition being false which would get displayed when progress value is 0. This was fixed using ternary operator instead. And also the label would get hidden at low progress values which is now
Fixes #696
Type of change
How Has This Been Tested?
Tested by trying to set the progress value to zero in the storybook.
Checklist: