Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar): adds missing className #657

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

rluders
Copy link
Collaborator

@rluders rluders commented Mar 6, 2023

Description

className was present on Sidebar, 'cause it extends div, but it wasn't working properly. This PR, adds the className to the end of CSS classes, as we have in other components.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Breaking changes

No

How Has This Been Tested?

  • Manual test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@rluders rluders requested a review from tulup-conner March 6, 2023 08:27
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (525b90d) 99.42% compared to head (54bf32b) 99.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #657   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files         130      130           
  Lines        6439     6440    +1     
  Branches      481      481           
=======================================
+ Hits         6402     6403    +1     
  Misses         37       37           
Impacted Files Coverage Δ
src/lib/components/Sidebar/Sidebar.tsx 100.00% <100.00%> (ø)
src/lib/theme/default.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

tulup-conner
tulup-conner previously approved these changes Mar 7, 2023
@tulup-conner tulup-conner force-pushed the fix/sidebar-classname branch from 1ed957e to 97c0991 Compare March 7, 2023 04:57
@tulup-conner tulup-conner added this to the 1.0.0 milestone Mar 7, 2023
@rluders rluders force-pushed the fix/sidebar-classname branch from 97c0991 to 54bf32b Compare March 8, 2023 10:05
@rluders rluders merged commit 12fce11 into themesberg:main Mar 8, 2023
@rluders rluders deleted the fix/sidebar-classname branch March 8, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants