Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toast): ToastToggle must have className #471

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

rluders
Copy link
Collaborator

@rluders rluders commented Dec 5, 2022

Description

Adds access to className to ToastToggle component.

Fixes #444

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Breaking changes

N/A

How Has This Been Tested?

  • Unit test

Test Configuration:

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@rluders rluders requested a review from tulup-conner December 5, 2022 21:54
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 97.34% // Head: 97.34% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (e4a217f) compared to base (cd26e24).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         127      127           
  Lines        5348     5349    +1     
  Branches      436      436           
=======================================
+ Hits         5206     5207    +1     
  Misses        142      142           
Impacted Files Coverage Δ
src/lib/components/Toast/ToastToggle.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rluders rluders merged commit 5618b21 into themesberg:main Dec 6, 2022
@rluders rluders deleted the fix/toast-toggle-classname branch December 6, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Classnames not adding to <Toast.Toggle className="here" />
2 participants