Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): fix welcome page #377

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

baterson
Copy link
Contributor

@baterson baterson commented Oct 10, 2022

Description

Fixes #372

Welcome page is broken because of mdx-js/react v2 it doesn't work after React18 update.
Here the opened issue which addresses this problem storybookjs/storybook#18094
And this is a possible way to fix it for now storybookjs/storybook#18094 (comment)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manualy by running storybook:start
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 98.61% // Head: 98.61% // No change to project coverage 👍

Coverage data is based on head (58749c7) compared to base (6f6a63a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          89       89           
  Lines        4116     4116           
  Branches      375      375           
=======================================
  Hits         4059     4059           
  Misses         57       57           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rluders rluders self-requested a review October 10, 2022 16:57
Copy link
Collaborator

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@rluders rluders merged commit d2518ad into themesberg:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Welcome page to Storybook setup doesn't show content
2 participants