Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons outline does not match specification #361

Closed
fs-innonova opened this issue Sep 21, 2022 · 3 comments · Fixed by #376
Closed

Buttons outline does not match specification #361

fs-innonova opened this issue Sep 21, 2022 · 3 comments · Fixed by #376
Labels
🐛 bug Something isn't working confirmed This bug was confirmed help wanted Extra attention is needed

Comments

@fs-innonova
Copy link

If we set the outline prop to true the Button component does not behave as in the docs

expected outcome:
image

current outcome:
image

Why is it so thick? Am I missing something? Thank you

@rluders
Copy link
Collaborator

rluders commented Sep 21, 2022

Well, this is at least strange. I was checking the classes applied to the button and it should be forced to focus:!ring-2 but the normal one is focus:ring-4, the same as standard flowbite docs.

Anyway, maybe we need to do some extra tailwind configuration or update some dependencies?

NOTE: sometimes given the fact that flowbite and flowbite-react are separated libraries, some differences from the standard library could happen. Flowbite-react components lives here: https://flowbite-react.com/

@rluders rluders added 🐛 bug Something isn't working help wanted Extra attention is needed confirmed This bug was confirmed labels Sep 21, 2022
@iamgideonidoko
Copy link
Contributor

@rluders Can I work on this?

@rluders
Copy link
Collaborator

rluders commented Oct 9, 2022

@iamgideonidoko go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working confirmed This bug was confirmed help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants