Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): fix next button icon misalignment #346

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

paulmach
Copy link
Contributor

@paulmach paulmach commented Sep 5, 2022

Description

The wrong class was referenced, copy-paste issues probably.

Fixes #330

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change contains documentation update

Breaking changes

None

How Has This Been Tested?

Visually

Screen Shot 2022-09-05 at 9 47 20 AM

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #346 (da12aa4) into main (70b9df4) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files          89       89           
  Lines        4105     4105           
  Branches      374      374           
=======================================
  Hits         4034     4034           
  Misses         71       71           
Impacted Files Coverage Δ
src/lib/components/Pagination/index.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rluders rluders self-requested a review September 6, 2022 07:56
Copy link
Collaborator

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulmach thanks.

@rluders rluders merged commit 0dd10d3 into themesberg:main Sep 6, 2022
@paulmach paulmach deleted the fix330 branch September 6, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination component button icon size misalignment
2 participants