Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): minimal react version is 18 #344

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

rluders
Copy link
Collaborator

@rluders rluders commented Aug 29, 2022

Description

The package.json was saying that the minimal requirement to the librabry was react and react-dom 17. It isn't true.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Breaking changes

n/a

How Has This Been Tested?

  • Unit tests

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@rluders rluders requested a review from tulup-conner August 29, 2022 18:16
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #344 (92f40dc) into main (70b9df4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files          89       89           
  Lines        4105     4105           
  Branches      374      374           
=======================================
  Hits         4034     4034           
  Misses         71       71           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rluders rluders merged commit bc4fea7 into themesberg:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant