Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): add z-index to Dropdown floating component #314

Merged
merged 4 commits into from
Jul 31, 2022

Conversation

tulup-conner
Copy link
Collaborator

Breaking changes

None.

**Note: ** You can now import CustomFlowbiteTheme directly:

import type { CustomFlowbiteTheme } from "flowbite-react";

Bug fixes

Misc

`.prettierignore` was misconfigured to ignore these
folders, which contain the vast majority of the source
files.
…act`

You can now `import type { CustomFlowbiteTheme } from "flowbite-react"`, rather than typing out the
path to the compiled `ESM` module for `Flowbite` component.
Generally, the `Dropdown` theme doesn't seem to reflect what is currently on the `flowbite` docs
(https://flowbite.com/docs/components/dropdowns/), so I made changes to reflect that.

resolve themesberg#308
@tulup-conner tulup-conner requested a review from rluders July 30, 2022 23:08
@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #314 (41faa35) into main (bfef57a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
- Coverage   99.13%   99.13%   -0.01%     
==========================================
  Files         133      133              
  Lines        8287     8276      -11     
  Branches      953      955       +2     
==========================================
- Hits         8215     8204      -11     
  Misses         72       72              
Impacted Files Coverage Δ
src/lib/components/Dropdown/index.tsx 100.00% <100.00%> (ø)
src/lib/components/Floating/index.tsx 100.00% <100.00%> (ø)
src/lib/components/Flowbite/index.tsx 84.31% <100.00%> (ø)
src/lib/components/Footer/FooterCopyright.tsx 100.00% <100.00%> (ø)
src/lib/components/Footer/FooterLink.tsx 100.00% <100.00%> (ø)
src/lib/components/Footer/FooterTitle.tsx 100.00% <100.00%> (ø)
src/lib/components/FormControls/Radio.tsx 100.00% <100.00%> (ø)
src/lib/components/FormControls/Select.tsx 100.00% <100.00%> (ø)
src/lib/components/FormControls/Textarea.tsx 100.00% <100.00%> (ø)
src/lib/components/Navbar/NavbarBrand.tsx 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfef57a...41faa35. Read the comment docs.

@rluders rluders merged commit 77cb356 into themesberg:main Jul 31, 2022
@rluders rluders linked an issue Jul 31, 2022 that may be closed by this pull request
@tulup-conner tulup-conner deleted the fix/dropdown-transparent branch July 31, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Dropdown Component Background is Transparent
2 participants