Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): toggleSwitch add sizing prop (sm|md|lg) #1009

Merged
merged 1 commit into from
Sep 29, 2023
Merged

feat(component): toggleSwitch add sizing prop (sm|md|lg) #1009

merged 1 commit into from
Sep 29, 2023

Conversation

MateoWartelle
Copy link
Contributor

@MateoWartelle MateoWartelle commented Sep 28, 2023

Summarize the changes made and the motivation behind them.

Sizing (sm|md|lg) for ToggleSwitch component
I added some storybook example for now.
The examples will be on its own /docs/forms/toggleswitch page being worked on in #998.

Reference related issues using # followed by the issue number.

#998

If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.

added sizing prop. Not a breaking change. default is still md (which has class w-11 h-6 ...)

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 2:10am

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 487 lines in your changes are missing coverage. Please review.

Comparison is base (7461173) 99.54% compared to head (320feb7) 93.45%.
Report is 95 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1009      +/-   ##
==========================================
- Coverage   99.54%   93.45%   -6.10%     
==========================================
  Files         163      182      +19     
  Lines        6621     7911    +1290     
  Branches      401      442      +41     
==========================================
+ Hits         6591     7393     +802     
- Misses         30      518     +488     
Files Coverage Δ
src/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/components/Banner/index.ts 100.00% <100.00%> (ø)
src/components/Breadcrumb/theme.ts 100.00% <100.00%> (ø)
src/components/Button/Button.tsx 100.00% <100.00%> (ø)
src/components/Button/ButtonBase.tsx 100.00% <100.00%> (ø)
src/components/Button/theme.ts 100.00% <100.00%> (ø)
src/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/components/Carousel/Carousel.tsx 99.10% <100.00%> (+0.13%) ⬆️
src/components/DarkThemeToggle/DarkThemeToggle.tsx 100.00% <100.00%> (ø)
src/components/Datepicker/index.ts 100.00% <100.00%> (ø)
... and 47 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, @MateoWartelle. Thanks.

@rluders rluders merged commit c3bf704 into themesberg:main Sep 29, 2023
2 of 4 checks passed
maman pushed a commit to transkripid/flowbite-react that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants