Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue #846 - docs dropdown - custom trigger section not render… #1005

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: issue #846 - docs dropdown - custom trigger section not render… #1005

merged 1 commit into from
Sep 27, 2023

Conversation

SutuSebastian
Copy link
Collaborator

Docs: dropdown - fix custom trigger section not rendering properly ES6 callback in code-preview.

Reference related issues using # followed by the issue number.
#846

Before

Screenshot 2023-09-27 at 12 39 26

After

Screenshot 2023-09-27 at 12 38 43

@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 9:45am

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 487 lines in your changes are missing coverage. Please review.

Comparison is base (7461173) 99.54% compared to head (90b0ac8) 93.44%.
Report is 93 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1005      +/-   ##
==========================================
- Coverage   99.54%   93.44%   -6.11%     
==========================================
  Files         163      182      +19     
  Lines        6621     7902    +1281     
  Branches      401      442      +41     
==========================================
+ Hits         6591     7384     +793     
- Misses         30      518     +488     
Files Coverage Δ
src/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/components/Banner/index.ts 100.00% <100.00%> (ø)
src/components/Breadcrumb/theme.ts 100.00% <100.00%> (ø)
src/components/Button/Button.tsx 100.00% <100.00%> (ø)
src/components/Button/ButtonBase.tsx 100.00% <100.00%> (ø)
src/components/Button/theme.ts 100.00% <100.00%> (ø)
src/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/components/Carousel/Carousel.tsx 99.10% <100.00%> (+0.13%) ⬆️
src/components/DarkThemeToggle/DarkThemeToggle.tsx 100.00% <100.00%> (ø)
src/components/Datepicker/index.ts 100.00% <100.00%> (ø)
... and 46 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ing properly ES6 callback in `code-preview`
@rluders rluders merged commit 409c01c into themesberg:main Sep 27, 2023
2 of 4 checks passed
@SutuSebastian SutuSebastian deleted the fix/issue/846 branch September 27, 2023 10:09
maman pushed a commit to transkripid/flowbite-react that referenced this pull request Oct 7, 2023
…not render… (themesberg#1005)

fix: issue themesberg#846 - docs dropdown - `custom trigger` section not rendering properly ES6 callback in `code-preview`

Co-authored-by: Sebastian Sutu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants