Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Browser does not always indicate what file is selected #17

Open
ThiconZ opened this issue Nov 25, 2021 · 2 comments
Open

File Browser does not always indicate what file is selected #17

ThiconZ opened this issue Nov 25, 2021 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@ThiconZ
Copy link
Member

ThiconZ commented Nov 25, 2021

When a file or folder is clicked on in the File Browser, there is not always an indication that it is now selected. It appears the item is given a highlight, which matches the "light" alternate color when listing items, only if it matches the search pattern and is a file. This makes it very difficult to tell when a file even is selected, and which folder may be selected.

@ThiconZ ThiconZ added enhancement New feature or request bug Something isn't working labels Nov 25, 2021
@GoomiiV2
Copy link
Member

Can you show a screenshot?

@ThiconZ
Copy link
Member Author

ThiconZ commented Nov 26, 2021

Screenshot of "cimnodes.dll" file selected using the ImTool default Corporate Grey theme.
image

Screenshot of "cimnodes.dll" file selected using the Visual Studio Dark theme for imgui.
image

Screenshot of "ref" folder selected using the ImTool default Corporate Grey theme.
image

Screenshot of "runtimes" folder selected using the ImTool default Corporate Grey theme.
image

It appears the highlight color for files is using an existing theme style instead of potentially modifying an existing one automatically (making the style color being lighter if using a dark theme, or darker if using a light theme). In some imgui themes this results in the selected file color being identical to the lighter color used when rendering the file list using alternating colors.

From what I can tell, folders that are selected in the OpenFile(s) mode do not get highlighted at all when selected. After testing it more, those folders are not navigated into when the confirmation button (such as Open) is clicked while in OpenFile mode. This is inconsistent with standard (non-imtool) File browser behavior. The issue here appears that the folders are not actually be set as "selected" at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants