Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings view crashes after updating local path #50

Closed
theiskaa opened this issue Feb 5, 2022 · 1 comment · Fixed by #51
Closed

Settings view crashes after updating local path #50

theiskaa opened this issue Feb 5, 2022 · 1 comment · Fixed by #51
Assignees
Labels
bug Something isn't working
Milestone

Comments

@theiskaa
Copy link
Owner

theiskaa commented Feb 5, 2022

When we update the local path and then try to view(open) settings file with the editor, it returns a stupid error:

❯ notya settings view

 [ERROR] Note not exists at: .settings.json

It happens 'cause we use [serivce]'s open functionality, which that uses l.settings.LocalPath + notePath to define the file(note) path.
So notya tries to reach settings file at new local_path, but settings file won't be moved in any case.

@theiskaa theiskaa added the bug Something isn't working label Feb 5, 2022
@theiskaa theiskaa added this to the v0.2.0 milestone Feb 5, 2022
@theiskaa theiskaa self-assigned this Feb 5, 2022
@theiskaa theiskaa linked a pull request Feb 6, 2022 that will close this issue
@theiskaa
Copy link
Owner Author

theiskaa commented Feb 6, 2022

Resolved by: #51

@theiskaa theiskaa closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant