Allowing starting tsserver as a module using cp.fork #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Open in Gitpod - starts a development workspace for this pull request in code review mode and opens it in a browser IDE. |
mattlyons0
reviewed
Nov 8, 2018
| @@ -102,7 +102,10 @@ export class TspClient { | |||
| this.cancellationPipeName = tempy.file({ name: 'tscancellation' } as any); | |||
| args.push('--cancellationPipeName', this.cancellationPipeName + '*'); | |||
| this.logger.info(`Starting tsserver : '${tsserverPath} ${args.join(' ')}'`); | |||
| this.tsserverProc = cp.spawn(tsserverPath, args); | |||
| const tsserverPathIsModule = path.extname(tsserverPath) === ".js"; | |||
There was a problem hiding this comment.
Maybe should support ".mjs" as well
|
So this is a more conservative version of #78, I like it. The trade off is that you actually have to point to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, tsserver could only be started as an executable, which would often run the
.bin/tsserverfile that uses a Node shebang to starttsserver.jsusing the first Node on the$PATH.With this PR, tsserver can also be started as a module, by setting
tsserverPathso it points totsserver.js. Also, when tsserver is bundled with the TS LSP server, it will be started usingcp.fork, so it uses the same version of Node as the TS LSP server.This PR is related to #78