Return null when resolving completion request at an invalid location #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return null when resolving completion request at an invalid location, as is allowed by the LSP spec. Before this CR, asking for a completion request at a location where no completions can be provided, such immediately after the
b
in the codefunction b
, would cause the server to return anErrorCodes.InternalError
.The reason for this is that tsserver, when you ask for completions at a nonsense location, returns a response with
success === false
(ref). We then reject the tsp request Promise (here), and this rejected Promise is never caught so it is later translated to an internal error.