respect URIs received from clients #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Open in Gitpod - starts a development workspace for this pull request in code review mode and opens it in a browser IDE. |
This PR makes sure that a server only normalizes URIs for internal computation, but sends responses and notification with client URIs. Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov
force-pushed
the
ak/respect_client_uris
branch
from
3a9d7e7 to
6ea400b
Compare
mattlyons0
added a commit
to mattlyons0/ide-typescript-theia
that referenced
this pull request
Sep 17, 2018
Fixes issue with path resolution on windows: typescript-language-server/typescript-language-server#75
akosyakov
changed the title
svenefftinge
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that a server only normalizes URIs for internal computation, but sends responses and notification with client URIs.
It's motivated by atom/ide-typescript#127 (comment)