Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global plugins support #73

Merged
merged 3 commits into from
Sep 14, 2018
Merged

global plugins support #73

merged 3 commits into from
Sep 14, 2018

Conversation

akosyakov
Copy link
Contributor

@akosyakov akosyakov commented Sep 14, 2018

TODO:

  • testing in Theia with global tslint plugin

It resolves #58 by allowing clients to provide globally installed plugins.

Signed-off-by: Anton Kosyakov <[email protected]>
Signed-off-by: Anton Kosyakov <[email protected]>
@gitpod-io-legacy-app
Copy link

Open in Gitpod - starts a development workspace for this pull request in code review mode and opens it in a browser IDE.

@akosyakov akosyakov force-pushed the ak/global_plugins_support branch from b964d21 to 3dff990 Compare September 14, 2018 07:42
@akosyakov akosyakov force-pushed the ak/global_plugins_support branch from 3dff990 to 366aecb Compare September 14, 2018 07:54
@akosyakov akosyakov changed the title WIP global plugins support global plugins support Sep 14, 2018
@akosyakov
Copy link
Contributor Author

It works nicely in Theia: eclipse-theia/theia#2878

@svenefftinge could you try it out too and review this PR?

Copy link
Contributor

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@akosyakov akosyakov merged commit 6c86709 into master Sep 14, 2018
@akosyakov akosyakov deleted the ak/global_plugins_support branch September 14, 2018 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint/tslint support
2 participants