Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[problems] add a preference to control tree problem decorators #6021

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes #6019

  • added a new preference to control whether to enable/disable
    problem decorators (diagnostic markers) in tree widgets.
  • updated the problems.decorations.tabbar.enabled preference name.

How to test

  • open a workspace
  • open a file and create an error
  • the explorer tree decoration should be enabled for the file
  • open the preferences widget, and disable the preference problems.decorations.enabled
  • the explorer decorations should be turned off
  • re-enable the preference problems.decorations.enabled
  • the explorer decorations should be turned on

Review checklist

Reminder for reviewers

Signed-off-by: Vincent Fugnitto [email protected]

@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves problems issues related to the problems widget labels Aug 22, 2019
@vince-fugnitto vince-fugnitto self-assigned this Aug 22, 2019
Copy link

@fangnx fangnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! A very useful preference.

Fixes #6019

- added a new preference to control whether to enable/disable
problem decorators (diagnostic markers) in tree widgets.
- updated the `problems.decorations.tabbar.enabled` preference name.

Signed-off-by: Vincent Fugnitto <[email protected]>
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-wise looks good

@akosyakov
Copy link
Member

@vince-fugnitto Could we nominate @fangnx as a committer? He did quite complex changes already and his review should be counted.

@vince-fugnitto
Copy link
Member Author

@vince-fugnitto Could we nominate @fangnx as a committer? He did quite complex changes already and his review should be counted.

He did in fact complete very nice complex changes that improved the app as a whole :)
Unfortunately, @fangnx's 4-month internship has just completed (last Friday) and he will be returning to school full-time so I wasn't 100% sure about nomination since he wouldn't be as active anymore.

cc @marcdumais-work

@vince-fugnitto vince-fugnitto merged commit da3c2eb into master Aug 26, 2019
@vince-fugnitto vince-fugnitto deleted the vf/GH-6019 branch August 26, 2019 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves problems issues related to the problems widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[navigator] add a preference to turn on/off the display of problem decorators
3 participants