[task] update 'run selected text' isVisible and isEnabled handling #6018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
enhancement
RomanNikitenko
approved these changes
Aug 23, 2019
There was a problem hiding this comment.
I tested the changes, it works as described in the description of the PR:
Run Selected Textis disabled if I don't have open an editorRun Selected Textis enabled and I can run some command if I have open an editor
I faced with another problem when I tested the changes, I checked it for master branch and created the separated issue: #6027 because it's not related to the PR changes.
vince-fugnitto
force-pushed
the
vf/GH-6017
branch
from
71c308e to
c2d7083
Compare
|
@RomanNikitenko I updated the PR with a fix for #6027, can you confirm if it works correctly now for you? |
|
I've tested more and it doesn't look like the bug is completely fixed yet. |
Fixes #6017 - previously the command `Task: Run Selected Text` was always enabled and visible which lead to a poor user experience when no editor was currently opened. The handling for `isVisible` and `isEnabled` was updated to determine if an editor is currently opened using the `EditorManager`. Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/GH-6017
branch
from
c2d7083 to
be6dfc0
Compare
|
I'll see if I can fix #6027 as a separate pr and find the root cause of the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #6017
Task: Run Selected Textwas alwaysenabled and visible which lead to a poor user experience when
no editor was currently opened. The handling for
isVisibleandisEnabledwas updated to determine if an editor is currently openedusing the
EditorManager.How to test
Taskmenu and verify if the menu itemRun Selected Textis disabledTaskmenu and verify that the menu itemRun Selected Textis enabledReview checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto [email protected]