Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin] Fix ignoreFocusOut parameter for the QuickPick #5900

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Aug 9, 2019

What it does

Pass ignoreFocusOut parameter to QuickOpenService on showQuickPick API function.

fixes #5882

How to test

  1. Open https://github.com/microsoft/vscode-extension-samples/tree/master/quickinput-sample project
  2. Add ignoreFocusOut: true, after line https://github.com/microsoft/vscode-extension-samples/blob/5fb626a4e383c41b8878f94045cff987b92b6bca/quickinput-sample/src/basicInput.ts#L14
    and build the plugin.
  3. Start the plugin, launch F1 => Quick Input Samples => showQuickPick

The opened quick-pick must be visible after clicking to the area out of the widget.

Without the fix the quick pick widget hides after clicking to the area out of the widget, even if the ignoreFocusOut parameter is set.

Review checklist

Reminder for reviewers

@akosyakov
Copy link
Member

Start the plugin, launch F1 => Quick Input Samples => showQuickPick

What should we expect to get what was not working before?

@vinokurig
Copy link
Contributor Author

updated the description with old behavior

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works correctly 👍

I tested against master using the extension you mentioned and the quickPick is dismissed when
the area around it is clicked. With your change, I can see that the quickPick is preserved when clicking outside it's area.

@akosyakov akosyakov added the vscode issues related to VSCode compatibility label Aug 9, 2019
Copy link
Contributor

@tetchel tetchel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for QuickPick. I would like to see the same change for InputBox :)

@akosyakov
Copy link
Member

@vinokurig how hard is to apply to input box? Could it be done in this PR?

@vinokurig
Copy link
Contributor Author

@akosyakov It should already work with InputBox, I've tested it by modifying the input-box action in the vscode quick-input sample.

@akosyakov
Copy link
Member

@tetchel #5882 can be closed with this PR according to #5900 (comment), right? Could you provide a reproducible example if it does not work?

@tetchel
Copy link
Contributor

tetchel commented Aug 12, 2019

confirmed it does work for inputbox. sorry, from the PR description i assumed it was quickinput only. So this does fix #5882

@akosyakov
Copy link
Member

@vinokurig please merge

@vinokurig vinokurig merged commit 63e865f into master Aug 13, 2019
@vinokurig vinokurig deleted the fixIgnoreFocusOut branch August 13, 2019 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vscode] ignoreFocusOut option is not respected for InputBox and QuickPick
4 participants