-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plugin] Fix ignoreFocusOut parameter for the QuickPick #5900
Conversation
Signed-off-by: Igor Vinokur <[email protected]>
What should we expect to get what was not working before? |
updated the description with old behavior |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works correctly 👍
I tested against master
using the extension you mentioned and the quickPick is dismissed when
the area around it is clicked. With your change, I can see that the quickPick is preserved when clicking outside it's area.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for QuickPick
. I would like to see the same change for InputBox
:)
@vinokurig how hard is to apply to input box? Could it be done in this PR? |
@akosyakov It should already work with |
@tetchel #5882 can be closed with this PR according to #5900 (comment), right? Could you provide a reproducible example if it does not work? |
confirmed it does work for inputbox. sorry, from the PR description i assumed it was quickinput only. So this does fix #5882 |
@vinokurig please merge |
What it does
Pass
ignoreFocusOut
parameter toQuickOpenService
onshowQuickPick
API function.fixes #5882
How to test
ignoreFocusOut: true,
after line https://github.com/microsoft/vscode-extension-samples/blob/5fb626a4e383c41b8878f94045cff987b92b6bca/quickinput-sample/src/basicInput.ts#L14and build the plugin.
The opened quick-pick must be visible after clicking to the area out of the widget.
Without the fix the quick pick widget hides after clicking to the area out of the widget, even if the
ignoreFocusOut
parameter is set.Review checklist
Reminder for reviewers