core: catch command handler errors #5894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
force-pushed
the
mp/command-handler-error
branch
from
033fdc3 to
8e30373
Compare
|
It works really well! I was able to test by throwing errors for a command on both 
It also fixes the issue #827 👍 |
|
@marechal-p please see #5898 You should fix and handle |
paul-marechal
force-pushed
the
mp/command-handler-error
branch
from
8e30373 to
3098b10
Compare
If a contribution throws an error during basic lifecycle steps, it might kill whatever is trying to iterate over all the contributions. A better strategy would be to catch errorred handlers and keep looking for other contributions. Also fix `.getToggledHandler` to not stop prematurely and actually test if the handler is toggled or not. Signed-off-by: Paul Maréchal <[email protected]>
paul-marechal
force-pushed
the
mp/command-handler-error
branch
from
3098b10 to
3d28b10
Compare
|
Fixed. |
akosyakov
approved these changes
Aug 9, 2019
There was a problem hiding this comment.
code looks good time
@vince-fugnitto could you give it a go please and if you are fine, let's merge
|
It still works correctly on my end :) |
paul-marechal
commented
Aug 9, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
fix #5898 - catches command handler errors.
Also fix bug where
getToggledHandlerwould stop on the first handler with aisToggledfunction defined, without executing it.How to test
Modify some command handler to throw errors, without this patch it can prevent the command palette from opening. With this change, the error will be reported but it will not stop the processing of other contributions.
Review checklist
Reminder for reviewers