-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear the superfluous scrollbars at the DebugConfigurationWidget and DebugToolBar #5879
Conversation
@AlexTugarev please try whether it behaves as you expect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works really well, I no longer see the superfluous scrollbar from the debug configuration and toolbar widgets. Nice work 👍
@@ -51,6 +51,11 @@ export class DebugConfigurationWidget extends ReactWidget { | |||
this.toDispose.push(this.manager.onDidChange(() => this.update())); | |||
this.toDispose.push(this.workspaceService.onWorkspaceChanged(() => this.update())); | |||
this.toDispose.push(this.workspaceService.onWorkspaceLocationChanged(() => this.update())); | |||
this.scrollOptions = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @xieyuanhuata for fixing this issue!
I'm generally fine with disabling perfect scroll bar as as, but why should it be created in the first place?
I think unsetting it in ctor
like this would also to the job. @akosyakov is there a use for the scrollbar at all in those two widgets?
constructor() {
super();
this.scrollOptions = undefined;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexTugarev I agree with your opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, unsetting like @AlexTugarev suggested should work as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexTugarev @akosyakov
you are right! Unsetting like @AlexTugarev suggested work as well.
@vince-fugnitto @AlexTugarev when you are fine please help with landing @xieyuanhuata don't have write access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that it also works correctly to unset the scrollbar for the debug config and toolbar widgets.
Just as an FYI you can add the following line:
this.scrollOptions = undefined
Directly in the:
@postConstruct()
protected init(): void { ... }
@vince-fugnitto I think the effect is the same in ctor and init(). Maybe init is better |
It's up to you, both work fine :) ( |
Signed-off-by: xieyuanhu <[email protected]>
What it does
fix #5819 - Clear the superfluous scrollbars for debug widgets
before:
after:
How to test
Open debug
Moves the mouse to the right of the DebugConfigurationWidget or DebugToolBar border
Review checklist
Reminder for reviewers