fix: [Plugin-API] complete QuickPick hide api

[hacke2]

Fixes #5765

What it does

See https://code.visualstudio.com/api/references/vscode-api#QuickPick.

Hides this input UI. This will also fire an QuickInput.onDidHide event.

when execute hide method, vscode will:

• Hide UI
• Emit onDidHide event

But theia only emit onDidHide event.

How to test

import * as vscode from 'vscode';

export function activate(context: vscode.ExtensionContext) {
  const disposable = vscode.commands.registerCommand('hide QuickPick after 2000ms', () => {
    const quickOpen = vscode.window.createQuickPick();

    quickOpen.items = [
      { label: 'A' }, {label: 'B'}
    ];

    quickOpen.show();

    setTimeout(() => {
       quickOpen.hide();
     }, 2000);
  });

  context.subscriptions.push(disposable);
}

Review checklist

• as an author, I have thoroughly tested my changes and carefully reviewed following the review guidelines

Reminder for reviewers

• as a reviewer, I agree to review in accordance with the review guidelines

[akosyakov]

@hacke2 please follow https://github.com/theia-ide/theia/blob/ak/pr_template/doc/pull-requests.md#review-reqs

[hacke2]

@akosyakov I don't know how to test plugin in theia but I'm sure it's effective in monaco 0.14.

[kittaakos]

how to test plugin in theia

@hacke2, here is a Wiki page describing how to test it: https://github.com/theia-ide/theia/wiki/Testing-VS-Code-Extensions
If you have any feedback on the docs, let us know. I'll make the adjustments.

[hacke2]

@akosyakov @kittaakos I've tested it. No problem.

What should I do next?

[akosyakov]

@hacke2 wait, someone has to verify it independently

[kittaakos]

@hacke2, please squash your commits, and I do the review. Thanks!

[hacke2]

@kittaakos Done.

[hacke2]

Add a Gif

[kittaakos]

@hacke2, can you share the package.json of your extension? I am trying to follow the steps defined here to verify your changes. Thanks!

[kittaakos]

can you share the package.json of your extension?

Never mind. I added your example: kittaakos/vscode-extension-samples@7f1230c

[kittaakos]

I have verified it. Without the changes, the Command Palette does not close automatically after the 2000 ms timeout, it works with the changes. 👍

I am OK with the Theia related modifications, @benoitf are you OK with the plugin API?

[JPinkney]

If its possible can we try to get this merged asap, I'm currently working on fixes for #5187. In order to fix up the comments I have to go back and re-do the way the createQuickPick API works and it would be easier to build ontop of this if its expected to go through

[kittaakos]

@JPinkney, sure. Please find someone who approves the plugin API, and we can merge.

[akosyakov]

please take care of a comment before merging

structural mismatch

[akosyakov]

@hacke2 thank you for the contribution

code-wise looks good, merging since changes were already tested