[search-in-workspace] fix search-in-workspace search result info

[vince-fugnitto]

Fixes #5698

• fixes an issue where the message No Results Found. is displayed
  as a user types and attempts to search. The problem is that the message
  is displayed before the search actually completes due to a update().
  Instead, the update to the widget is performed once the search-in-workspace-tree
  completes it's search and fires the event onDidChange().

Signed-off-by: Vincent Fugnitto [email protected]

[vince-fugnitto]

@lmcbout please let me know if the behavior is better this way.

[lmcbout]

@vince-fugnitto Much much better. Display "" instead of "No result found" while searching is better
code wise: ok
test: ok

[vince-fugnitto]

@jbicker I removed the update from the search, I do not know if it will have any bad repercussions.

The idea I had was that it shouldn't be the search() that updates the widget, but rather the search-in-workspace-tree through the onChange event which informs us that it completed the search and the tree is updated. Do you see any problem with this approach?

I am trying to fix the issue of intermediate states before the search is complete and the user is typing to not render the search-info div.

[jbicker]

Seems to be ok. I actually don't remember why the update() was called in the search-Method.
Works still as it should without it (but without the superfluous 'nothing found' note).