-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[file-dialog] fix scaling issue for the file and save dialogs #5688
Conversation
Ohh, finally <3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works like a charm. Very nice! 👍
Would it be possible to generalize the following classes:
.dialogContent .theia-FileDialog,
.dialogContent .theia-SaveFileDialog {
width: 500px;
}
.dialogContent .theia-FileDialog {
height: 500px;
background-color: var(--theia-layout-color0);
}
.dialogContent .theia-SaveFileDialog {
height: 450px;
}
And have the same height
and background-color
for both the open file and save file dialogs. Generalize your changes a bit too. So when we add a third dialog later, we do not have to apply
@media only screen and (max-height: 700px) {
.dialogContent .theia-MyThirdDialog {
height: 300px;
}
}
If it is not possible, or does not worth the effort, let's merge your changes as is. It is already a great improvement.
Sure, I can make the updates and improvements you suggested, glad you think its an improvement already :) |
Fixes #1935 - added the `theia-ResponsiveFileDialog` class so extenders can easily use the class to get the default styling of the `file-dialog` and its responsive media query. Our `file-dialog` and `save-dialog` have scaling issues when the screen's viewport is limited. Since our dialogs are not implemented using React (which would handle scaling much easier), the problem was addressed using css media queries. This means that when the view becomes limited at 700px, the size of the `file-tree` is reduced allowing the entire dialog to more easily visible and the actions buttons still accessible. Before, the buttons were not visible which meant the useability of the dialog was reduced. Signed-off-by: Vincent Fugnitto <[email protected]>
a2137e5
to
a7fe72c
Compare
@kittaakos I added a new class extenders can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works nicely. 👍
Fixes #1935
theia-ResponsiveFileDialog
class so extenders can easily use the class to get the default styling of thefile-dialog
and its responsive media query.Our
file-dialog
andsave-dialog
have scaling issues when the screen's viewport is limited. Since our dialogs are not implemented using React (which would handle scaling much easier), the problem was addressed using css media queries. This means that when the view becomes limited at 700px, the size of thefile-tree
is reduced allowing the entire dialog to more easily visible and theactions buttons still accessible.
Before, the buttons were not visible which meant the useability
of the dialog was reduced.
Signed-off-by: Vincent Fugnitto [email protected]