support linux and osx specific command properties #5579
Conversation
|
@RomanNikitenko @azatsarynnyy I went through the source code of Theia and VS Code, looks like neither have OS-specific command properties support in the plugin-ext (extensionHost in VS Code). So I guess, plugin developers are supposed to deal with the operating system specific stuffs in the plugin code. Am I right ? |
elaihau
force-pushed
the
task_osx_linux
branch
2 times, most recently
from
0df348e to
f175c54
Compare
|
@elaihau OS specific properties can be defined for the |
|
I've tested the PR on Linux - it works well. |
|
could we test on mac together @marechal-p when you have time ? |
| systemSpecificCommand = this.getSystemSpecificCommand(taskConfig, 'osx'); | ||
| } else { // on linux | ||
| if (taskConfig.linux !== undefined) { // linux-specific options, if available, take precedence | ||
| systemSpecificCommand = this.getSystemSpecificCommand(taskConfig, 'linux'); |
There was a problem hiding this comment.
Unfortunately, I don't have a chance to test it on Windows/MacOS.
Let's assume I have the following task which I'm going run on Windows/MacOS:
{
"label": "Run Dev",
"type": "shell",
"command": ".\\scripts\\code.bat",
"linux": {
"command": "./scripts/code.sh"
}
}If I understand it right, Theia would try to execute the command from linux.command property. Isn't it?
There was a problem hiding this comment.
if you run that task on Windows/OSX, ".\scripts\code.bat" should be run. linux.command is only for execution on linux.
please correct me if my code is wrong.
There was a problem hiding this comment.
hmm, i see what you mean - there is a bug with the if - else logic here. let me do more testing and fix it.
elaihau
force-pushed
the
task_osx_linux
branch
2 times, most recently
from
72579be to
feac4ad
Compare
- as per https://github.com/microsoft/vscode/blob/1.35.1/src/vs/workbench/contrib/tasks/common/taskConfiguration.ts#L255, vsCode supports having separated command properties for Windows, OSX, and Linux. This change adds the same support to Theia. - changed the `command` property in CommandProperties interface from mandatory to optional. - part of eclipse-theia#5516 Signed-off-by: elaihau <[email protected]>
|
Tested on mac with @marechal-p . Also added mac-specific unit tests as per his comments. |
commandproperty in CommandProperties interface from mandatory to optional.Signed-off-by: elaihau [email protected]