-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plug-in][doc] Breaking behavior change in Theia plug-ins #5743
Comments
The entry should be enough (or failing with how to fix the plug-in) Regarding che, all our plug-ins have already been updated for that change. |
Ok, let's update the changelog then.
For VS Code extensions, we won't do it. It will be incorrect. I am asking only about Theia plugins. |
yes I understood, I was just saying that it's better to align behavior between theia plug-in and VSCode extension |
Fixes #5743 Signed-off-by: Akos Kitta <[email protected]>
Thank you all for the clarification. |
Fixes #5743 Signed-off-by: Akos Kitta <[email protected]>
After checking #5738 we realized that from now on, it is a must to add the following to the
package.json
of any Theia plug-ins:Otherwise, it won't activate.
Instead of forcing clients to update their package.json content with the wildcard
activationEvents
, we could check if thetheiaPlugin
top level property exists in thepackage.json
and if it has either thebackend
or thefrontend
props. If so, but theactivationEvents
is not defined, we can infer a wildcard. So the Theia plug-in can still start without any modifications. Thoughts?CC: @benoitf
The text was updated successfully, but these errors were encountered: