-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plug-in] Implement 'workbench.action.debug.restart` (vscode-java-debug) command #5102
Comments
It's a matter of renaming an existing command: https://github.com/theia-ide/theia/blob/e147cf39c7f484374b7ec0cd0d04958c3ef00bca/packages/debug/src/browser/debug-frontend-application-contribution.ts#L75 Please add a breaking note in CHANGELOG. |
I also think so, but will the only renaming be enough? Under what version I shoud add my chahges? The latest one we have in CHANGELOG.md is |
@vrubezhny you should for sure check with your extension whether it is enough and put a comment on the PR that other double check it during review. yes |
Having the command renamed from
I was able to reproduce the following error:
For some reasons in most cases HotCodeReplace was silently failing without any error indications logged with this version of |
…ug) command #5102 Signed-off-by: Victor Rubezhny <[email protected]>
Description
'workbench.action.debug.restart` VS Code API command is missing from Language Support Plugins used in Che 7 GA.
https://github.com/Microsoft/vscode-docs/blob/master/docs/editor/debugging.md#debug-actions
Reproduction Steps
Found by the code coverage tool, see: eclipse-che/che#13007
OS and Theia version:
Diagnostics:
The text was updated successfully, but these errors were encountered: