Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minified build removes space in site footer #81

Closed
jcrd opened this issue Mar 3, 2021 · 2 comments
Closed

Minified build removes space in site footer #81

jcrd opened this issue Mar 3, 2021 · 2 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@jcrd
Copy link

jcrd commented Mar 3, 2021

Building with hugo --minify combines the lines in this span element so there is no space between 'and' and the heart:

image

@xoxys xoxys added the bug Something isn't working label Mar 3, 2021
@xoxys
Copy link
Member

xoxys commented Mar 3, 2021

Thanks for your report! We'll look into this.

@xoxys
Copy link
Member

xoxys commented Mar 3, 2021

After some testing I have to say we will not spend effort on this. It's not just the heart but also some other places where spaces between HTML elements matters but were stripped... Some of these issues are related to gohugoio/hugo#6892. As the benefit is very low compared to the required effort this won't be fixed, sorry. While recommendation like "don't depend on whitespace in your layout" sounds nice, it seems to be not that straight forward especially for something like embedded icons into the text flow.

The recommendation for this theme is to disable HTML in the minify options:

minify:
  disableHTML: true

@xoxys xoxys added the wontfix This will not be worked on label Mar 3, 2021
@xoxys xoxys closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants