Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Link to 3.1.0 #2

Open
thegamecracks opened this issue Dec 28, 2023 · 1 comment
Open

Upgrade Link to 3.1.0 #2

thegamecracks opened this issue Dec 28, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@thegamecracks
Copy link
Owner

As of v1.0.4, LinkPython-extern compiles with Link 3.0.6 while the latest version is 3.1.0.

I attempted to upgrade Link but encountered issues with libatomic unable to be linked during the build workflow for Linux, as discovered in #1. Help in getting build_wheels.yml to work would be appreciated!
See also: https://github.com/thegamecracks/link-python/actions/runs/7350399232/job/20011982698

@thegamecracks thegamecracks added enhancement New feature or request help wanted Extra attention is needed labels Dec 28, 2023
@thegamecracks
Copy link
Owner Author

thegamecracks commented Jun 19, 2024

Since GitHub has cleared the logs of the linked workflow run, I've re-ran the build on a new bump-link branch based off of link-python v1.1.0a1 with Link updated to 3.1.1, and downloaded an archive of the logs:

logs_25062170451.zip

ubuntu-latest was the first to fail on Step 3: Build wheels. Here's a snippet of the log from lines 384-391:

2024-06-19T02:09:13.3563381Z       -- Build files have been written to: /project/build/temp.linux-x86_64-cpython-37/LinkPython-extern
2024-06-19T02:09:13.3564156Z       [1/2] Building CXX object CMakeFiles/_link.dir/src/Link.cpp.o
2024-06-19T02:09:13.3565151Z       [2/2] Linking CXX shared module /project/build/lib.linux-x86_64-cpython-37/_link.cpython-37m-x86_64-linux-gnu.so
2024-06-19T02:09:13.3566148Z       FAILED: /project/build/lib.linux-x86_64-cpython-37/_link.cpython-37m-x86_64-linux-gnu.so
2024-06-19T02:09:13.3568594Z       : && /opt/rh/devtoolset-10/root/usr/bin/c++ -fPIC -O3 -DNDEBUG  -flto -shared  -o /project/build/lib.linux-x86_64-cpython-37/_link.cpython-37m-x86_64-linux-gnu.so CMakeFiles/_link.dir/src/Link.cpp.o  -latomic  -lpthread && cd /project/build/temp.linux-x86_64-cpython-37/LinkPython-extern && /opt/rh/devtoolset-10/root/usr/bin/strip /project/build/lib.linux-x86_64-cpython-37/_link.cpython-37m-x86_64-linux-gnu.so
2024-06-19T02:09:13.3571210Z       /opt/rh/devtoolset-10/root/usr/libexec/gcc/x86_64-redhat-linux/10/ld: cannot find -latomic
2024-06-19T02:09:13.3571914Z       collect2: error: ld returned 1 exit status
2024-06-19T02:09:13.3572383Z       ninja: build stopped: subcommand failed.

Here are the corresponding lines in the workflow run page while it's still up:
https://github.com/thegamecracks/link-python/actions/runs/9574996374/job/26399138246#step:3:384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant