Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #32847 - job wizard description field with user data #605

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Fixes #32847 - job wizard description field with user data #605

merged 2 commits into from
Sep 16, 2021

Conversation

MariaAga
Copy link
Member

depends on: #555 #556

@MariaAga MariaAga changed the title 32847 Fixes #32847 - job wizard description field with user data Jun 25, 2021
@MariaAga MariaAga mentioned this pull request Jul 13, 2021
Merged
@MariaAga MariaAga marked this pull request as ready for review August 31, 2021 12:13
@MariaAga
Copy link
Member Author

@LaViro can you take a look? :)

MariaAga pushed a commit to MariaAga/foreman_remote_execution that referenced this pull request Sep 3, 2021
@adamruzicka
Fixes #31677 - Emit events when tasks stop (theforeman#605)
b13236d 
Adds an Action extension implementing an Foreman event emmiting.

Actions which should emit events when they stop need to include the
::Actions::ObservableAction module in them. The event is only emitted when the
action is the entry action of an execution plan.

This is a workaround until Foreman exposes plugin API for event registration[1].

[1] - https://projects.theforeman.org/issues/31647
adamruzicka
adamruzicka reviewed Sep 8, 2021
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One slight deviation from how it used to work, apart from it it works well

webpack/JobWizard/steps/AdvancedFields/DescriptionField.js Outdated Show resolved Hide resolved
Ron-Lavi
Ron-Lavi approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@Ron-Lavi Ron-Lavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MariaAga !

@adamruzicka adamruzicka merged commit 4e746a2 into theforeman:master Sep 16, 2021
@adamruzicka
Copy link
Contributor

Thank you @MariaAga & @LaViro !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ron-Lavi Ron-Lavi Ron-Lavi approved these changes

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MariaAga @adamruzicka @Ron-Lavi @theforeman-bot