Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theforeman.foreman.content_credential shouldn't need to specify content parameter when state=absent #1588

Closed
bschonec opened this issue Apr 11, 2023 · 2 comments · Fixed by #1589
Closed

theforeman.foreman.content_credential shouldn't need to specify content parameter when state=absent #1588

bschonec opened this issue Apr 11, 2023 · 2 comments · Fixed by #1589

Comments

@bschonec
Copy link

bschonec commented Apr 11, 2023 •
edited
Loading

Is it necessary to specify content: parameter when deleting (state: absent) a content credential? IMHO, you shouldn't have to specify the content of the credential itself in order to delete it. You should just be able to delete it.
@evgeni
Copy link
Member

evgeni commented Apr 11, 2023

Yepp, you're right. For deleting only the name should be necessary.

@evgeni evgeni linked a pull request Apr 12, 2023 that will close this issue
don't require content_type and content parameters when removing #1589
Merged
@evgeni
Copy link
Member

evgeni commented Apr 12, 2023

Opened #1589 with a fix

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

don't require content_type and content parameters when removing theforeman/foreman-ansible-modules
2 participants
@evgeni @bschonec