Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-download wasm-opt if not present #139

Closed
3 tasks done
thedodd opened this issue Mar 5, 2021 · 1 comment
Closed
3 tasks done

Auto-download wasm-opt if not present #139

thedodd opened this issue Mar 5, 2021 · 1 comment
Labels
assets Build pipelines for specific asset types cli Trunk CLI application enhancement New feature or request

Comments

@thedodd
Copy link
Member

thedodd commented Mar 5, 2021

Now that the work in #115 has landed (thanks @dnaka91), we should be clear to start working on the auto-download of wasm-opt.

  • if a user has explicitly set wasm-opt level to 0 (off), then we should suppress any attempt to fetch wasm-opt (let's give the user some control so that they don't end up in a frustrating situation).
  • let's update the default to 3 or 4 (@dnaka91 probably has a good recommendation here) so that it will be invoked by default.
  • have a look at Leverage wasm-pack to handle wasm-bindgen installs & other awesomeness #5. It appears as though there is already some good work on this front which we could leverage.
@thedodd thedodd added enhancement New feature or request cli Trunk CLI application assets Build pipelines for specific asset types labels Mar 5, 2021
@thedodd
Copy link
Member Author

thedodd commented Jul 28, 2021

Done.

@thedodd thedodd closed this as completed Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Build pipelines for specific asset types cli Trunk CLI application enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant