Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple deprecation warnings for PHP8.4 implicit nullable parameters #480

Closed
icanhazstring opened this issue Dec 2, 2024 · 6 comments
Closed

Comments

@icanhazstring
Copy link

Multiple errors when using this library on any dependency.
At the moment this is used for simplyfy/easy-coding-standard which throws a lot of deprecations.

I can't list the all, because basically each file contains deprecations errors for PHP8.4.

@staabm
Copy link
Collaborator

staabm commented Dec 2, 2024

duplicate of #442

@staabm staabm closed this as completed Dec 2, 2024
@icanhazstring
Copy link
Author

How can this be closed?
The contained changes for the linked issue are not solving all the problems.

@staabm
Copy link
Collaborator

staabm commented Dec 2, 2024

the changes are not yet released.

@icanhazstring
Copy link
Author

icanhazstring commented Dec 2, 2024

That I get. But master still has tons of issues. Like here for one:

https://github.com/thecodingmachine/safe/blob/master/generated/zlib.php#L511
https://github.com/thecodingmachine/safe/blob/master/generated/zlib.php#L301
https://github.com/thecodingmachine/safe/blob/master/generated/zlib.php#L330

This is just one file.
This continues basically for almost all files still.

So even when switching to dev-master all the issues persist?

@staabm
Copy link
Collaborator

staabm commented Dec 2, 2024

the generated files are not yet up2date. we are still sorting the new release.

we could need help with the generator if you are up to the task

@icanhazstring
Copy link
Author

Ah I see. Thanks for the info.
I might take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants