Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

\Safe\fgetcsv should never return false #356

Closed
leo108 opened this issue May 11, 2022 · 3 comments · Fixed by #362
Closed

\Safe\fgetcsv should never return false #356

leo108 opened this issue May 11, 2022 · 3 comments · Fixed by #362

Comments

@leo108
Copy link

leo108 commented May 11, 2022

It throws exception if fgetcsv returns false

https://github.com/thecodingmachine/safe/blob/master/generated/filesystem.php#L268-L270
@dbrekelmans
Copy link
Collaborator

@leo108 Could you provide more information? I'm not sure I understand what the issue is.

@leo108
Copy link
Author

leo108 commented May 16, 2022

@dbrekelmans if fgetcsv returns false, it will throw FilesystemException, \Safe\fgetcsv will never return false.

@leo108
Copy link
Author

leo108 commented May 16, 2022

false should be removed from the @return doc

https://github.com/thecodingmachine/safe/blob/master/generated/filesystem.php#L250

@Kharhamel Kharhamel mentioned this issue Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX: regenerated the files without losing support for date thecodingmachine/safe
2 participants
@leo108 @dbrekelmans