Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to Vitest 2 #690

Merged
merged 5 commits into from
Jul 11, 2024
Merged

feat: upgrade to Vitest 2 #690

merged 5 commits into from
Jul 11, 2024

Conversation

thebuilder
Copy link
Owner

@thebuilder thebuilder commented Jul 10, 2024 •
edited
Loading

  • Types cleanup in test-utils, getting rid of @types/jest (replaced with vitest)
  • Move test mocking setup from beforeEach to beforeAll
  • Upgrade to Vitest 2
  • Add basic browser mode test, that runs with an unmocked IntersectionObserver

@stackblitz StackBlitz
Copy link

stackblitz bot commented Jul 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel Vercel
Copy link

vercel bot commented Jul 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-intersection-observer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 7:35am

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 10, 2024 •
edited
Loading

commit: f72e455

react-intersection-observer

npm i https://pkg.pr.new/thebuilder/react-intersection-observer@690

@thebuilder thebuilder mentioned this pull request Jul 10, 2024
Closed
@thebuilder thebuilder changed the title test: upgrade to Vitest 2, and add browser testing feat: upgrade to Vitest 2, and add browser testing Jul 11, 2024
@thebuilder thebuilder changed the title feat: upgrade to Vitest 2, and add browser testing feat: upgrade to Vitest 2 Jul 11, 2024
@thebuilder thebuilder merged commit 054adf4 into main Jul 11, 2024
17 checks passed
@thebuilder thebuilder deleted the feat/vitest-2 branch July 11, 2024 08:12
@thebuilder
Copy link
Owner Author

🎉 This issue has been resolved in version 9.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Artur-data-DEV Artur-data-DEV mentioned this pull request Aug 1, 2024
Open
@NiallJoeMaher NiallJoeMaher mentioned this pull request Aug 2, 2024
Merged
@xan187 xan187 mentioned this pull request Aug 2, 2024
Open
@bohdandone bohdandone mentioned this pull request Aug 7, 2024
Open
@onsails onsails mentioned this pull request Aug 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thebuilder