Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup response handling and improve error tests. #60

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Cleanup response handling and improve error tests. #60

merged 5 commits into from
Aug 9, 2023

Conversation

jeffdav
Copy link
Contributor

@jeffdav jeffdav commented Aug 8, 2023

  • Fix a few more places where the Response associated type was now wrong.
  • Add some additional tests to cover previously uncovered APIs.

@jeffdav jeffdav requested a review from stevenbrix August 8, 2023 21:48
@jeffdav jeffdav mentioned this pull request Aug 8, 2023
Closed
compnerd
compnerd reviewed Aug 9, 2023
View reviewed changes
Tests/UnitTests/APIToRequestMappingTests.swift Outdated Show resolved Hide resolved
Tests/WebDriverTests/NotepadTests.swift Outdated Show resolved Hide resolved
Tests/WebDriverTests/NotepadTests.swift Outdated Show resolved Hide resolved
Tests/WebDriverTests/SessionTests.swift Outdated Show resolved Hide resolved
Tests/WebDriverTests/SessionTests.swift Outdated Show resolved Hide resolved
@jeffdav jeffdav requested a review from compnerd August 9, 2023 18:13
@jeffdav jeffdav merged commit 4f70372 into main Aug 9, 2023
@jeffdav jeffdav deleted the jeff/cleanup-response-handling branch August 9, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@stevenbrix stevenbrix Awaiting requested review from stevenbrix

@tristanlabelle tristanlabelle Awaiting requested review from tristanlabelle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdav @compnerd