Do not merge command-line options and nox.options in place #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When merging options specified in the noxfile and on the command-line option, do not use the output parameter `command_args` as the input for the merge; instead, copy `command_args` initially and pass the copy to the merge functions. Merge functions such as `_session_filters_merge_func` inspect `command_args` to see if other options have been specified on the command-line. When the options are merged in place, this check produces false positives. For example, `nox.options.sessions` is copied into `command_args` as a part of the merge; so it will appear to have been specified on the command-line when merging `nox.options.pythons`, causing the latter to be ignored.
This was referenced Nov 13, 2020
theacodes
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #356
When merging options specified in the noxfile and on the command-line, do not use the output parameter
command_argsas the input for the merge. Instead, copycommand_argsinitially and pass the copy to the merge functions.Merge functions such as
_session_filters_merge_funcinspectcommand_argsto see if other options have been specified on the command-line. When the options are merged in place, this check produces false positives.For example,
nox.options.sessionsis copied intocommand_argsas a part of the merge. So it will appear to have been specified on the command-line when mergingnox.options.pythons, causing the latter to be ignored.