Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing component constructor should throw RemoteInvocationException #85

Closed
yallie opened this issue Dec 2, 2024 · 2 comments
Closed

Comments

@yallie
Copy link
Collaborator

yallie commented Dec 2, 2024

Describe the bug
When a component constructor throws an exception, it should be sent to the client.

To Reproduce

public class TestService()
{
	public TestService() => throw new NotImplementedException();
}

Expected behavior
The client should get a RemoteInvocationException wrapping the actual exception thrown by the component.

Additional notes
This issue is related to this: #69

@yallie
Copy link
Collaborator Author

yallie commented Dec 3, 2024

Looks like the underlying issue is this:

ISerializable type 'Castle.MicroKernel.ComponentActivator.ComponentActivatorException' 
does not have a valid constructor. To correctly implement ISerializable a constructor 
that takes SerializationInfo and StreamingContext parameters should be present. Path ''.

@yallie
Copy link
Collaborator Author

yallie commented Dec 4, 2024

Blacklisted the ComponentActivatorException so it doesn't break the RemotingClient message processing loop.

@yallie yallie closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant