Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readjust to fit screen #27

Open
daviortega opened this issue Jun 19, 2017 · 3 comments
Open

readjust to fit screen #27

daviortega opened this issue Jun 19, 2017 · 3 comments
Assignees
Milestone

Comments

@daviortega
Copy link
Member

This is just the code that can do that... must be applied into the button requested by other issue #22

@tkukavica1
Copy link
Member

Would you like that anytime the window is resized that the tree readjusts to fit screen, or just when the button is pressed?

@daviortega
Copy link
Member Author

Good question...

We should probably discuss on how we want the system to behave as a whole, but the button should be able to just resize the the tree to fit the current screen size.

I guess ideally the system should behave like this:

  1. when you load a tree, the tree fits the screen by default.
  2. If you collapse a node, the tree keeps with the fit to screen on.
  3. if you zoom in or out, the fit to screen unlocks but now as the size of the screen changes, it changes the size of the tree proportionally so the part of the tree that is displayed stays the same.
  4. if you collapse a node in this case, the tree reajusts the spacing to keep the distances between leaves as it was before.
  5. the whole thing is resized to fit to screen at any moment if the user press the button again.

Hard... but I think this is the ideal goal here.

@tkukavica1
Copy link
Member

The fit to screen button now has functionality the way I was envisioning it to...not quite sure I understand how you would ideally like collapsing to work. We will discuss this when we meet, but for now I'll move it to "Needs Review".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants