Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weapon Materials of 2.0 does not return weapon list #35

Closed
sephalias opened this issue Aug 5, 2021 · 2 comments
Closed

Weapon Materials of 2.0 does not return weapon list #35

sephalias opened this issue Aug 5, 2021 · 2 comments

Comments

@sephalias
Copy link

var genshinDb = require("genshin-db")

console.log(genshinDb.weapons("narukami", {matchCategories:true}))

Return: undefined

Also with Mask and Branch of Distant Sea

@theBowja
Copy link
Owner

theBowja commented Aug 5, 2021

Good catch. Looks like I forgot to add the upgrade costs to the searchable categories. I will fix this today.

@theBowja
Copy link
Owner

theBowja commented Aug 5, 2021

fixed with commit bf901b0
available in v3.9.3
example:

genshindb.characters('arrowhead', { matchCategories: true })
[ 'Amber', 'Diona', 'Fischl' ]

@theBowja theBowja closed this as completed Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants