Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Cost" in Hideout Profit is incorrect #128

Closed
bferrantino opened this issue Jul 10, 2022 · 5 comments
Closed

"Cost" in Hideout Profit is incorrect #128

bferrantino opened this issue Jul 10, 2022 · 5 comments

Comments

@bferrantino
Copy link

It seems that the "Cost" values in the Hideout Profit page are showing the SELL-To-Trader prices, not the BUY-From-Flea/Trader prices

For example:
Lavatory > Max Energy Drink > TarCola shows a Cost of 2507, which is the SELL-To-Trader Price (Therapist), however the BUY-From-Flea Price is over 39k. See below example shows Hideout Profit page showing 2,507, but Item page showing 39k
image
image

Some items are working fine, but it only seems to work correctly when there is a Trader who actually sells the item, but when no Trader sells the item, it seems to show the Sell-To-Trader Price instead. See below example of Bottle of Water, which shows correctly in the above Hideout Profit image
image

Thank you!
p34nUt

@Shebuka
Copy link
Contributor

Shebuka commented Jul 10, 2022

You have no access to flea market, this means that you can't sell/buy the item from the flea, that means you can only sell the item to traders, so with this in mind the hideout profit shows how much you will profit if instead of selling items to traders you use them to craft something (and then sell it to flea market once you have it unlocked)

@bferrantino
Copy link
Author

@Shebuka ah ok, that makes sense. i did realize i didn't have "Has Flea" checked in the Settings later, but never went back to Hideout Profit. I have checked this morning, and now the numbers are more accurate.
Thanks for clarifying!

@Shebuka
Copy link
Contributor

Shebuka commented Jul 10, 2022

BTW, there is the problem that this is not well communicated in the interface, if you have any advice on how we can improve it feel free to leave a suggestion ;)

Also, I don't know if it's correct to calculate against the sell price on flea if you have no flea access... but that's an entirely different topic mentioned already in #125

@bferrantino
Copy link
Author

@Shebuka yea, if there was a note that explained it, I would've understood. Maybe have "Cost" change to something like "Trader Sell" if you have no Flea Access. Or add another column that calculates "Trader Sell" along with Cost.
Hard to really show it in the best way, but even a note at the top that says "You do not have Flea, so the prices below reflect Sale Price to Trader, rather than Cost" or something similar to what you said in the comment above

@Shebuka
Copy link
Contributor

Shebuka commented Jul 10, 2022

Yeah... Things get complicated. You can actually, even without the Flea Market, buy something from traders, like Water and Bandages... So in the same column, we may have both items you can only sell to traders and something you can also buy from them...
I was thinking about making the font of a different colour, like grey with a little of red, and add a tooltip that says something like "You can only sell this item to a trader".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants