Rate limiting strategy #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebrown32
force-pushed
the
rate_limiting
branch
4 times, most recently
from
78898bf to
f690969
Compare
mike-marcacci
requested changes
May 12, 2021
There was a problem hiding this comment.
This looks great (and so sorry for the slow review from me). This is a great API for this and solid collection of places to limit. I do think we could optimize the algorithm a bit – it's not clear to me that the existing one would actually be a problem in practice, but it does have high time complexity in the hot path. I proposed a possible alternative, but I may have missed some edge case there, so if you find issues with it, I'm OK starting with the original one.
Co-authored-by: Mike Marcacci <[email protected]>
mike-marcacci
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple implementation that sends 429s if callers do too many invocations of any credential, client, or authorization in a given minute. It uses a simple in-memory per-node rate limiting scheme.